Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check instgen interface #346

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Check instgen interface #346

merged 2 commits into from
Apr 29, 2020

Conversation

kthielen
Copy link
Contributor

This will let us flag this error earlier (type class instance generator with member set not covering its class): #343

@kthielen kthielen requested review from smunix and chenkai036 April 27, 2020 15:08
@kthielen kthielen self-assigned this Apr 27, 2020
@kthielen kthielen force-pushed the check-instgen-interface branch from 924193d to a08c655 Compare April 27, 2020 15:16
@chenkai036 chenkai036 merged commit b300868 into morganstanley:master Apr 29, 2020
@chenkai036
Copy link
Contributor

thanks @kthielen

@kthielen kthielen deleted the check-instgen-interface branch April 29, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenkai036 chenkai036 chenkai036 approved these changes

@smunix smunix Awaiting requested review from smunix

Assignees

@kthielen kthielen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kthielen @chenkai036