Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UsingTestingSequence to enforce simpler & correct usage #475

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open
Prev Previous commit
Next Next commit
Add Use for TestingSequence
atifaziz committed Nov 26, 2019

Verified

This commit was signed with the committer’s verified signature.
GromNaN Jérôme Tamarelle
commit b6ea36c9aa7fb725a723a9f00e7c1e9ba379b3e0
7 changes: 2 additions & 5 deletions MoreLinq.Test/RankTest.cs
Original file line number Diff line number Diff line change
@@ -119,11 +119,8 @@ public void TestRankGroupedItems()
[Test]
public void TestRankOfHighestItemIsOne()
{
var result =
Enumerable.Range(1, 10).UsingTestingSequence(ts =>
ts.Rank().OrderBy(x => x).First());

Assert.AreEqual(1, result);
using (var ts = Enumerable.Range(1, 10).AsTestingSequence())
Assert.AreEqual(1, ts.Rank().OrderBy(x => x).First());
}

/// <summary>
18 changes: 11 additions & 7 deletions MoreLinq.Test/TestingSequence.cs
Original file line number Diff line number Diff line change
@@ -27,25 +27,29 @@ static class TestingSequence
internal static TestingSequence<T> Of<T>(params T[] elements) =>
new TestingSequence<T>(elements);

[Obsolete("Use " + nameof(UsingTestingSequence) + " instead.")]
internal static TestingSequence<T> AsTestingSequence<T>(this IEnumerable<T> source) =>
source != null
? new TestingSequence<T>(source)
: throw new ArgumentNullException(nameof(source));

public static TResult UsingTestingSequence<T, TResult>(this IEnumerable<T> source,
Func<TestingSequence<T>, TResult> user)
public static TResult[] Use<T, TResult>(this TestingSequence<T> source,
Func<TestingSequence<T>, IEnumerable<TResult>> user)
{
if (source == null) throw new ArgumentNullException(nameof(source));
if (user == null) throw new ArgumentNullException(nameof(user));

using (var ts = source.AsTestingSequence())
return user(ts);
return user(source).ToArray();
}

public static TResult[] UsingTestingSequence<T, TResult>(this IEnumerable<T> source,
Func<TestingSequence<T>, IEnumerable<TResult>> user) =>
source.UsingTestingSequence(ts => user(ts).ToArray());
Func<TestingSequence<T>, IEnumerable<TResult>> user)
{
if (source == null) throw new ArgumentNullException(nameof(source));
if (source is TestingSequence<T>) throw new ArgumentException("Source is already a testing sequence instance.");
if (user == null) throw new ArgumentNullException(nameof(user));

return source.AsTestingSequence().Use(user);
}
}

/// <summary>