Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Add simpler Unfold overload #1015

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
+104 −32
Draft

🚧 Add simpler Unfold overload #1015

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5938c8a
Add simpler "Unfold" overload
atifaziz Oct 14, 2023
a2a9721
Update with a more involved example
atifaziz Oct 15, 2023
0f59db9
Add unit tests
atifaziz Oct 19, 2023
48d3560
Swap result and state order
atifaziz Oct 19, 2023
d325375
Fix example per "swap result and state order"
atifaziz Oct 19, 2023
50fe930
Put result & state into own, nested, tuple
atifaziz Oct 20, 2023
09b30f0
Update overload count in read-me doc
atifaziz Oct 20, 2023
4fcd56f
Fix var reference in example doc
atifaziz Oct 20, 2023
005f7d4
Merge remote-tracking branch 'upstream/master' into simpler-unfold
atifaziz Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit tests
@atifaziz
atifaziz committed Oct 19, 2023
commit 0f59db9dbfec28400638338916cec3cdc3738e22
93 changes: 61 additions & 32 deletions MoreLinq.Test/UnfoldTest.cs
View file
Original file line number Diff line number Diff line change
@@ -17,80 +17,109 @@

namespace MoreLinq.Test
{
using System.Collections.Generic;
using System.Runtime.CompilerServices;
using NUnit.Framework;

[TestFixture]
public class UnfoldTest
{
[Test]
public void UnfoldInfiniteSequence()
{
var result = MoreEnumerable.Unfold(1, x => (Result: x, State: x + 1),
static IEnumerable<TestCaseData>
TestCaseData<T>(IEnumerable<T> source1,
IEnumerable<T> source2,
[CallerMemberName] string? callerMemberName = null) =>
new TestCaseData[]
{
new(source1) { TestName = $"{callerMemberName}(generator)" },
new(source2) { TestName = $"{callerMemberName}(state, generator, predicate, stateSelector, resultSelector)" },
};

static IEnumerable<TestCaseData> UnfoldInfiniteSequenceData() =>
TestCaseData(MoreEnumerable.Unfold(1, x => (true, State: x + 1, Result: x)),
MoreEnumerable.Unfold(1, x => (Result: x, State: x + 1),
_ => true,
e => e.State,
e => e.Result)
.Take(100);
e => e.Result));

[Test]
[TestCaseSource(nameof(UnfoldInfiniteSequenceData))]
public void UnfoldInfiniteSequence(IEnumerable<int> unfold)
{
var result = unfold.Take(100);
var expectations = MoreEnumerable.Generate(1, x => x + 1).Take(100);

Assert.That(result, Is.EqualTo(expectations));
}

[Test]
public void UnfoldFiniteSequence()
{
var result = MoreEnumerable.Unfold(1, x => (Result: x, State: x + 1),
static IEnumerable<TestCaseData> UnfoldFiniteSequenceData() =>
TestCaseData(MoreEnumerable.Unfold(1, x => x <= 100 ? (true, State: x + 1, Result: x) : default),
MoreEnumerable.Unfold(1, x => (Result: x, State: x + 1),
e => e.Result <= 100,
e => e.State,
e => e.Result);
e => e.Result));

[Test]
[TestCaseSource(nameof(UnfoldFiniteSequenceData))]
public void UnfoldFiniteSequence(IEnumerable<int> unfold)
{
var result = unfold;
var expectations = MoreEnumerable.Generate(1, x => x + 1).Take(100);

Assert.That(result, Is.EqualTo(expectations));
}

[Test]
public void UnfoldIsLazy()
{
_ = MoreEnumerable.Unfold(0, BreakingFunc.Of<int, (bool, int, int)>());

_ = MoreEnumerable.Unfold(0, BreakingFunc.Of<int, (int, int)>(),
BreakingFunc.Of<(int, int), bool>(),
BreakingFunc.Of<(int, int), int>(),
BreakingFunc.Of<(int, int), int>());
}


[Test]
public void UnfoldSingleElementSequence()
{
var result = MoreEnumerable.Unfold(0, x => (Result: x, State: x + 1),
static IEnumerable<TestCaseData> UnfoldSingleElementSequenceData() =>
TestCaseData(MoreEnumerable.Unfold(0, x => x == 0 ? (true, State: x + 1, Result: x) : default),
MoreEnumerable.Unfold(0, x => (Result: x, State: x + 1),
x => x.Result == 0,
e => e.State,
e => e.Result);
e => e.Result));

[Test]
[TestCaseSource(nameof(UnfoldSingleElementSequenceData))]
public void UnfoldSingleElementSequence(IEnumerable<int> unfold)
{
var result = unfold;
var expectations = new[] { 0 };

Assert.That(result, Is.EqualTo(expectations));
}

[Test]
public void UnfoldEmptySequence()
{
var result = MoreEnumerable.Unfold(0, x => (Result: x, State: x + 1),
static IEnumerable<TestCaseData> UnfoldEmptySequenceData() =>
TestCaseData(MoreEnumerable.Unfold(0, x => x < 0 ? (true, State: x + 1, Result: x) : default),
MoreEnumerable.Unfold(0, x => (Result: x, State: x + 1),
x => x.Result < 0,
e => e.State,
e => e.Result);
e => e.Result));

[Test]
[TestCaseSource(nameof(UnfoldEmptySequenceData))]
public void UnfoldEmptySequence(IEnumerable<int> unfold)
{
var result = unfold;
Assert.That(result, Is.Empty);
}

static IEnumerable<TestCaseData> UnfoldReiterationsReturnsSameResultData() =>
TestCaseData(MoreEnumerable.Unfold(1, n => (true, State: n + 1, Result: n)),
MoreEnumerable.Unfold(1, n => (Result: n, Next: n + 1),
_ => true,
n => n.Next,
n => n.Result));

[Test(Description = "https://github.com/morelinq/MoreLINQ/issues/990")]
public void UnfoldReiterationsReturnsSameResult()
[TestCaseSource(nameof(UnfoldReiterationsReturnsSameResultData))]
public void UnfoldReiterationsReturnsSameResult(IEnumerable<int> unfold)
{
var xs = MoreEnumerable.Unfold(1, n => (Result: n, Next: n + 1),
_ => true,
n => n.Next,
n => n.Result)
.Take(5);

var xs = unfold.Take(5);
xs.AssertSequenceEqual(1, 2, 3, 4, 5);
xs.AssertSequenceEqual(1, 2, 3, 4, 5);
}