enter product on invoice item does not copy price #44 Popcommerce #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in the IN parameter definition of create#PersonCustomer service, if newPassword field is empty, the UserAccount will be created and after this user will have to change or reset. But with the exiting newPassword check, it was blocking the creation of UserAccount, thus removed the additional check of newPassword.
…al/modified price
…was only partly issued, and always do separate AssetDetail records for the issuance reversal and the new reservation making it much easier to see history and avoid weird data combinations, also pass through shipmentId and other IDs relevant to AssetDetail records
…ments are partly or fully packed and shipped and then hard cancelled, still some to do
… cancel#AssetIssuance when there was an existing reservation
…r unavailable reservations; add reReserve#Assets service to bulk re-reserve existing reservations, new reservations initially always sorted by OrderPart.priority then OrderHeader.placedDate
…lc fields from ProductStore
… based on ShipmentItemSource if available, fixes issue where invoiceId/invoiceItemSeqId not set on AssetIssuance if invoice created before shipment
…temSeqId on AssetIssuance related to ShipmentItemSource for records where was missing
…ct parties are available
…ress support (like emailAddress) to get#PartyContactInfo, get#PartyContactInfoList, and store#PartyContactInfo
…ice for use on ShipmentDetail and PackShipment screens
address1 should be mandatory mantle.party.duplicateServices find#PostalAddresses is already mandatory if mssing the following will happen: Transaction rollback for [Error running service mantle.order.OrderInfoServices.check#OrderPreApprove (message): Field cannot be empty(for field Address 1 of service Mantle Party Duplicate Services Find Postal Addresses which make the order detail screen locked.
…ionId by from/thru dates, add pageNoLimit parameter for file output use
…w paymentMethodId and toPaymentMethodId
…ard() method to handle query string processing instead of inconsistent inline
…to project vendor or employer, ie without a project; move child/descendant WorkEffort logic to create#TimeEntryInvoiceItems from create#ProjectInvoiceItems; changes to all of these services to better handle invoice type and invoice item type for employee, non-employee person, and organization
…e format with empty line at end so adding signatures is hopefully more consistently a single line add in diffs
…erPartyList that defaults to all internal orgs if worker party has no employee relationships
… entity values were not looked up for existing open orders, and also constrain lookup of existing orders by vendorPartyId; related to PR #153
…lk rates and actual charges/rates add support for new ProductStoreShipOption markup fields that override the PsstShipLabelMarkup store setting if used, also honor the new ProductStore markupOrderShipLabels and markupShipmentShipLabels config fields
…ments and orders, support in services
…te are specified fromDate must be before thruDate, cleanup up some weird old logic for hours to only calc if null
…isted addresses make sure current address has a value for address1 which is required by the DuplicateServices.find#PostalAddresses service, and if no value add a different warning and don't call the service as it will result in an error
…ry and OrderItemShipBillSummary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.