Retry http requests #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove .json suffixes - record new responses for vcr - configure a custom vcr to ease re-recording
|
I really don't think the fix for a DNS problem belongs in application code like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #83. So it needs to be rebased.
This pull request is exposing a new config to control the number of retries when attempting to connect to soundcloud api. On my raspberrypi, the dns resolution fails on startup, thus mopidy fails to load the SoundCloud backend. I checked systemd config and requisites seems to be good. So my last resort is to increase the retries.
Also, a gently reminder about #85. Would be great to move forward 😄