Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demos #201

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Demos #201

wants to merge 7 commits into from

Conversation

SergioCrisostomo
Copy link
Member

Add demos to website.
(used Docs layout with ok from Pietro)

closes #162

@SergioCrisostomo SergioCrisostomo added this to the 1.1 milestone Jan 8, 2015
@SergioCrisostomo
Copy link
Member Author

bump...

@arian
Copy link
Member

arian commented Jan 24, 2015

I'm getting a 404 for /demos.

@arian
Copy link
Member

arian commented Jan 24, 2015

More fundamentally, what do we want to achieve with the demos, are they still representable?

@SergioCrisostomo
Copy link
Member Author

@arian sorry for the 404, fixed.

This PR fixes broken links to demos and makes easy importing demos, from the demos repo to the website.

If the demos are not representable (and I agree with you they need a update/upgrade) then we could/should ask the community to pimp them.
We could also remove the "Demos" header link in this PR so they are not present in the menu, still keeping them online and thus all the broken links working again.

@arian
Copy link
Member

arian commented Jan 24, 2015

I'd keep them out the main menu.

Some demos are a bit broken. For example:

Also the HTML highlighting is wrong. Maybe because the containing element has class="xml"?

@SergioCrisostomo
hide from menu, fix highlight, fix demos order
efb9d04 
 - hide “Demos” from menu
 - fix syntax highlight to detect css also
 - add colours for syntax highlight in css and xml/html tags
 - fix demo order that were being sorted alphabetically with
interference from file extension
@SergioCrisostomo
fix positioning inside main for demos
070e8c1
@SergioCrisostomo
Copy link
Member Author

@arian thanks for feedback!

Updated with:

  • removed link from menu
  • fixed highlight
  • fixed broken demos

@SergioCrisostomo SergioCrisostomo mentioned this pull request Feb 8, 2016
Open
@mootools mootools deleted a comment Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

main page API documentation
2 participants
@SergioCrisostomo @arian