Add a library menu item to load Famix SQL - Not working yet #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently trying to load FamixSQL ( https://github.com/moosetechnology/FamixSQL) will result in error due to the refactoring of WeakRegistry class in a dependency (https://github.com/pharo-rdbms/Pharo-ODBC) This can be bypassed by replacing the reference to WeakRegistry by FinalizationRegistry when loading it. There are two references to WeakRegistry inPharo-ODBC, ODBCConnection class>>#newConnections that can be fix at loading time and ODBCConnection>>#initializeStatements that can be fixed after. A pull request has been opened in Pharo-ODBC to fix it for the latest versions of Pharo and Moose (pharo-rdbms/Pharo-ODBC#11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @alesshosry
Currently trying to load FamixSQL (https://github.com/moosetechnology/FamixSQL) will result in an error due to the refactoring of
WeakRegistryclass in a dependency (https://github.com/pharo-rdbms/Pharo-ODBC)This can be bypassed by replacing the reference to
WeakRegistrybyFinalizationRegistrywhen loading it.There are two references to
WeakRegistryin Pharo-ODBC:ODBCConnection class>>#newConnectionsthat can be fixed at loading time andODBCConnection>>#initializeStatementsthat can be fixed after.A pull request has been opened in Pharo-ODBC to fix it for the latest versions of Pharo and Moose (pharo-rdbms/Pharo-ODBC#11). Once accepted, this feature should work and fix #1193