Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FamixStModel>>#newModelAddingAll: to create a new expanded model #766

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

Gabriel-Darbord
Copy link
Member

This simple method doesn't leave much room for configurability, but I'm not sure this feature needs it, as it's mainly a means to quickly expand an existing model.
Projects that automate model creation can use the already existing FamixStPharoImporterTask API.

The idea is that if you're toying with a model and realize you're missing some dependencies, then instead of recreating a model by hand which is tedious because you have to select all previous packages plus the new one(s), you can just use this method, e.g.:

"Add ByteString class and the package containing Association"
newModel := myModel newModelAddingAll: { ByteString. Association package }

@NicolasAnquetil
Copy link
Contributor

Is there an issue associated to this?
Can we discuss it? Whatr was the problem?
Because I din't understand why we would need a new method to add entities to a model ... ?

@Gabriel-Darbord
Copy link
Member Author

There's no issue, but it can be discussed here.
I gave the reasoning for this method in the original post:

The idea is that if you're toying with a model and realize you're missing some dependencies, then instead of recreating a model by hand which is tedious because you have to select all previous packages plus the new one(s), you can just use this method

Instead of using the UI to rebuild a larger model, you use this method.
This is useful for sandboxing.

@badetitou
Copy link
Member

I understand. Not sure it is mandatory, but if you have the case. Why not
Before merging need test first!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants