Fix AssertJ strategy

moosetechnology · May 13, 2024 · a2ae73e · a2ae73e
1 parent 57b7cb7
commit a2ae73e
Showing 1 changed file with 20 additions and 18 deletions.
diff --git a/src/Famix-UnitTest-Exporter/FamixUTAssertJJavaAssertionStrategy.class.st b/src/Famix-UnitTest-Exporter/FamixUTAssertJJavaAssertionStrategy.class.st
@@ -22,35 +22,37 @@ FamixUTAssertJJavaAssertionStrategy >> dependencyImportsOn: aFamixUTExporter [
 
 { #category : #exporting }
 FamixUTAssertJJavaAssertionStrategy >> export: aFamixUTAssertion on: exporter [
-	"Make an assertion using AssertJ: assertThat(actual).isEqualTo(expected)"
+	"Make an assertion using AssertJ: assertThat(actual).{options}.isEqualTo(expected)"
 
-	| model expected assertion containsObject |
+	| model expected assertion |
 	model := exporter model.
 	expected := aFamixUTAssertion expected.
 	assertion := model newMethodInvocation
 		             addArgument:
 			             (model newVariableExpression name: 'actual');
 		             name: 'assertThat'.
 	(self usingRecursiveComparison and: [
-		 containsObject := expected containsObject ]) ifTrue: [
-		assertion := model newMethodInvocation
-			             receiver: assertion;
-			             name: 'usingRecursiveComparison' ].
-	(self ignoringCollectionOrder and: [ expected containsCollection ])
+		 expected isOfObject or: [
+			 expected isOfCollection or: [ expected isOfDictionary ] ] ])
 		ifTrue: [
 			assertion := model newMethodInvocation
 				             receiver: assertion;
-				             name: 'ignoringCollectionOrder' ].
-	(self ignoringFieldsOfTypes isNotEmpty and: [
-		 containsObject ifNil: [ expected containsObject ] ]) ifTrue: [
-		assertion := model newMethodInvocation
-			             receiver: assertion;
-			             name: 'ignoringFieldsOfTypes';
-			             arguments:
-				             (ignoringFieldsOfTypes collect: [ :typeName |
-						              model newClassProperty
-							              type: (model newIdentifier name: typeName);
-							              fieldName: 'class' ]) ].
+				             name: 'usingRecursiveComparison'.
+			(self ignoringCollectionOrder and: [ expected containsCollection ])
+				ifTrue: [
+					assertion := model newMethodInvocation
+						             receiver: assertion;
+						             name: 'ignoringCollectionOrder' ].
+			(self ignoringFieldsOfTypes isNotEmpty and: [
+				 expected containsObject ]) ifTrue: [
+				assertion := model newMethodInvocation
+					             receiver: assertion;
+					             name: 'ignoringFieldsOfTypes';
+					             arguments:
+						             (ignoringFieldsOfTypes collect: [ :typeName |
+								              model newClassProperty
+									              type: (model newIdentifier name: typeName);
+									              fieldName: 'class' ]) ] ].
 	assertion := model newMethodInvocation
 		             receiver: assertion;
 		             addArgument: