Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle 429 api rate error #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle 429 api rate error #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/cargo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,19 @@ export async function saveCache() {
for (const cachePath of cachePaths) {
core.debug(`- ${cachePath}`);
}

await cache.saveCache(cachePaths, primaryKey);
for (let i = 1; i <= 10; i++) {
try {
return await cache.saveCache(cachePaths, primaryKey);
}
catch(error) {
const errStr = `${error}`
if (errStr.includes("Cache service responded with 429 during upload chunk")) {
core.info('Failed to upload cache, got rate limit error, waiting 30 seconds.');
await new Promise(f => setTimeout(f, 30000));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alon-dotan-starkware If a different error is thrown, we should probably rethrow that instead of retrying.

}
}
throw Error("Failed to upload cache.")
}

export async function restoreCache() {
Expand Down