Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Continuously pipe stdin during file hashing. #1864

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Mar 11, 2025

Fixes #1855

Copy link

github-actions bot commented Mar 11, 2025

Run report for 7e80eae4 (ubuntu-latest, 22)

Total time: 3m 1s | Comparison time: 3m 36s | Estimated savings: 34.5s (16.0% faster)

Action Time Status Info
🟩 SyncWorkspace 193.7ms Passed
🟩 SetupToolchain(node:~22) 33.4s Passed
🟩 SyncProject(node, types) 5.9ms Passed
🟩 SyncProject(node, runtime) 4.9ms Passed
🟩 SyncProject(node, report) 5.4ms Passed
🟩 SyncProject(node, nx-compat) 9ms Passed
🟩 SyncProject(node, website) 5.8ms Passed
🟩 InstallWorkspaceDeps(node:~22) 41.4s Passed
🟦 RunTask(types:build) 1.4s Cached
🟦 RunTask(runtime:typecheck) 83.8ms Cached
🟦 RunTask(report:lint) 112ms Cached
🟦 RunTask(report:test) 141.1ms Cached
🟦 RunTask(runtime:lint) 68ms Cached
🟦 RunTask(runtime:test) 101.1ms Cached
🟦 RunTask(report:typecheck) 77.5ms Cached
🟦 RunTask(nx-compat:test) 115.8ms Cached
🟦 RunTask(runtime:build) 463.2ms Cached
🟦 RunTask(nx-compat:typecheck) 70.2ms Cached
🟩 RunTask(runtime:format) 543.6ms Passed
🟦 RunTask(nx-compat:lint) 117.3ms Cached
And 9 more...
Expanded report
Action Time Status Info
🟦 RunTask(report:build) 643.7ms Cached
🟩 RunTask(report:format) 758.1ms Passed
🟦 RunTask(website:typecheck) 120.8ms Cached
🟦 RunTask(website:test) 141.8ms Cached
🟦 RunTask(website:lint) 142.3ms Cached
🟩 RunTask(nx-compat:format) 813.5ms Passed
🟦 RunTask(nx-compat:build) 1.2s Cached
🟩 RunTask(website:format) 9.7s Passed
🟩 RunTask(website:build) 1m 43s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 22
Touched files
CHANGELOG.md
crates/config/src/workspace/hasher_config.rs
crates/config/tests/workspace_config_test.rs
crates/process/src/command.rs
crates/process/src/command_line.rs
crates/process/src/exec_command.rs
crates/task-hasher/src/task_hasher.rs
crates/vcs/src/git.rs
crates/vcs/src/vcs.rs
crates/vcs/tests/git_test.rs
crates/workspace/src/workspace_builder.rs
website/docs/config/workspace.mdx

Copy link

Run report for 7e80eae4 (ubuntu-latest, 20)

Total time: 3m 9s | Comparison time: 3m 48s | Estimated savings: 38.9s (17.0% faster)

Action Time Status Info
🟩 SyncWorkspace 101ms Passed
🟩 SetupToolchain(node:~20) 31.6s Passed
🟩 SyncProject(node, types) 5.5ms Passed
🟩 SyncProject(node, nx-compat) 4.5ms Passed
🟩 SyncProject(node, report) 6.1ms Passed
🟩 SyncProject(node, runtime) 10.4ms Passed
🟩 SyncProject(node, website) 4.8ms Passed
🟩 InstallWorkspaceDeps(node:~20) 44s Passed
🟦 RunTask(types:build) 1.8s Cached
🟦 RunTask(runtime:lint) 88ms Cached
🟦 RunTask(runtime:typecheck) 120.1ms Cached
🟦 RunTask(runtime:test) 147.6ms Cached
🟦 RunTask(report:typecheck) 77.3ms Cached
🟦 RunTask(report:test) 126.2ms Cached
🟦 RunTask(report:lint) 71.9ms Cached
🟦 RunTask(runtime:build) 440.6ms Cached
🟦 RunTask(nx-compat:lint) 96.7ms Cached
🟦 RunTask(nx-compat:typecheck) 78.7ms Cached
🟩 RunTask(runtime:format) 546.8ms Passed
🟦 RunTask(nx-compat:test) 106.6ms Cached
And 9 more...
Expanded report
Action Time Status Info
🟦 RunTask(report:build) 785.9ms Cached
🟦 RunTask(website:typecheck) 126ms Cached
🟦 RunTask(website:test) 152ms Cached
🟩 RunTask(report:format) 840.2ms Passed
🟦 RunTask(website:lint) 133.3ms Cached
🟩 RunTask(nx-compat:format) 827.5ms Passed
🟦 RunTask(nx-compat:build) 1.3s Cached
🟩 RunTask(website:format) 10.3s Passed
🟩 RunTask(website:build) 1m 51s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20
Touched files
CHANGELOG.md
crates/config/src/workspace/hasher_config.rs
crates/config/tests/workspace_config_test.rs
crates/process/src/command.rs
crates/process/src/command_line.rs
crates/process/src/exec_command.rs
crates/task-hasher/src/task_hasher.rs
crates/vcs/src/git.rs
crates/vcs/src/vcs.rs
crates/vcs/tests/git_test.rs
crates/workspace/src/workspace_builder.rs
website/docs/config/workspace.mdx

Copy link

github-actions bot commented Mar 11, 2025

Run report for 7e80eae4 (ubuntu-latest, 18)

Total time: 1m 41s | Comparison time: 5m 16s | Estimated savings: 3m 34s (67.8% faster)

Action Time Status Info
🟩 SyncWorkspace 245.5ms Passed
🟩 SetupToolchain(node:~18) 31.1s Passed
🟩 SyncProject(node, types) 6.4ms Passed
🟩 SyncProject(node, report) 7.9ms Passed
🟩 SyncProject(node, runtime) 8.6ms Passed
🟩 SyncProject(node, nx-compat) 12ms Passed
🟩 SyncProject(node, website) 7ms Passed
🟩 InstallWorkspaceDeps(node:~18) 45.2s Passed
🟦 RunTask(types:build) 1.1s Cached
🟦 RunTask(runtime:typecheck) 73.4ms Cached
🟦 RunTask(runtime:test) 153.4ms Cached
🟦 RunTask(nx-compat:typecheck) 87ms Cached
🟦 RunTask(nx-compat:test) 120.3ms Cached
🟦 RunTask(runtime:build) 369.3ms Cached
🟦 RunTask(nx-compat:lint) 81.3ms Cached
🟦 RunTask(report:build) 526.4ms Cached
🟦 RunTask(report:typecheck) 92.7ms Cached
🟦 RunTask(runtime:lint) 97.7ms Cached
🟩 RunTask(report:format) 887.3ms Passed
🟦 RunTask(report:test) 143.1ms Cached
And 9 more...
Expanded report
Action Time Status Info
🟦 RunTask(report:lint) 93.8ms Cached
🟩 RunTask(nx-compat:format) 862.6ms Passed
🟦 RunTask(website:typecheck) 109.7ms Cached
🟦 RunTask(website:lint) 109ms Cached
🟦 RunTask(website:test) 135.3ms Cached
🟩 RunTask(runtime:format) 633.5ms Passed
🟦 RunTask(nx-compat:build) 994.6ms Cached
🟩 RunTask(website:format) 8.7s Passed
🟦 RunTask(website:build) 22.9s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18
Touched files
CHANGELOG.md
crates/config/src/workspace/hasher_config.rs
crates/config/tests/workspace_config_test.rs
crates/process/src/command.rs
crates/process/src/command_line.rs
crates/process/src/exec_command.rs
crates/task-hasher/src/task_hasher.rs
crates/vcs/src/git.rs
crates/vcs/src/vcs.rs
crates/vcs/tests/git_test.rs
crates/workspace/src/workspace_builder.rs
website/docs/config/workspace.mdx

Copy link

Run report for 7e80eae4 (windows-latest, 18)

Total time: 2m 3s | Comparison time: 6m 21s | Estimated savings: 4m 17s (67.5% faster)

Action Time Status Info
🟩 SyncWorkspace 351.8ms Passed
🟩 SetupToolchain(node:~18) 35.2s Passed
🟩 SyncProject(node, types) 8ms Passed
🟩 SyncProject(node, runtime) 6.1ms Passed
🟩 SyncProject(node, report) 8ms Passed
🟩 SyncProject(node, nx-compat) 9.7ms Passed
🟩 SyncProject(node, website) 6.4ms Passed
🟩 InstallWorkspaceDeps(node:~18) 1m 1s Passed
🟦 RunTask(types:build) 2.1s Cached
🟦 RunTask(runtime:typecheck) 330.9ms Cached
🟦 RunTask(report:test) 391.1ms Cached
🟦 RunTask(runtime:test) 569.3ms Cached
🟦 RunTask(runtime:lint) 176.9ms Cached
🟦 RunTask(report:typecheck) 209.8ms Cached
🟦 RunTask(nx-compat:typecheck) 231.5ms Cached
🟦 RunTask(runtime:build) 801.4ms Cached
🟦 RunTask(report:lint) 203.7ms Cached
🟦 RunTask(nx-compat:test) 303.4ms Cached
🟦 RunTask(nx-compat:lint) 240ms Cached
🟩 RunTask(runtime:format) 1.4s Passed
And 9 more...
Expanded report
Action Time Status Info
🟦 RunTask(report:build) 950.4ms Cached
🟩 RunTask(report:format) 1.8s Passed
🟦 RunTask(website:typecheck) 255ms Cached
🟩 RunTask(nx-compat:format) 1.7s Passed
🟦 RunTask(website:test) 443.9ms Cached
🟦 RunTask(website:lint) 235.7ms Cached
🟦 RunTask(nx-compat:build) 1.8s Cached
🟩 RunTask(website:format) 10.7s Passed
🟦 RunTask(website:build) 22.6s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18
Touched files
CHANGELOG.md
crates/config/src/workspace/hasher_config.rs
crates/config/tests/workspace_config_test.rs
crates/process/src/command.rs
crates/process/src/command_line.rs
crates/process/src/exec_command.rs
crates/task-hasher/src/task_hasher.rs
crates/vcs/src/git.rs
crates/vcs/src/vcs.rs
crates/vcs/tests/git_test.rs
crates/workspace/src/workspace_builder.rs
website/docs/config/workspace.mdx

Copy link

Run report for 7e80eae4 (windows-latest, 22)

Total time: 2m 13s | Comparison time: 6m 19s | Estimated savings: 4m 5s (64.7% faster)

Action Time Status Info
🟩 SyncWorkspace 312ms Passed
🟩 SetupToolchain(node:~22) 41.7s Passed
🟩 SyncProject(node, types) 9.2ms Passed
🟩 SyncProject(node, report) 6.3ms Passed
🟩 SyncProject(node, runtime) 8.3ms Passed
🟩 SyncProject(node, nx-compat) 9.9ms Passed
🟩 SyncProject(node, website) 6.7ms Passed
🟩 InstallWorkspaceDeps(node:~22) 1m 4s Passed
🟦 RunTask(types:build) 2s Cached
🟦 RunTask(runtime:typecheck) 199.3ms Cached
🟦 RunTask(report:lint) 265.2ms Cached
🟦 RunTask(runtime:test) 291.5ms Cached
🟦 RunTask(nx-compat:typecheck) 214.8ms Cached
🟦 RunTask(runtime:build) 666.3ms Cached
🟦 RunTask(runtime:lint) 198ms Cached
🟦 RunTask(report:typecheck) 169.1ms Cached
🟦 RunTask(report:build) 996.7ms Cached
🟦 RunTask(nx-compat:test) 258.4ms Cached
🟦 RunTask(report:test) 266.2ms Cached
🟦 RunTask(nx-compat:lint) 180.8ms Cached
And 9 more...
Expanded report
Action Time Status Info
🟩 RunTask(report:format) 1.7s Passed
🟩 RunTask(runtime:format) 1.5s Passed
🟦 RunTask(website:typecheck) 296.6ms Cached
🟦 RunTask(website:test) 331.2ms Cached
🟦 RunTask(website:lint) 228.3ms Cached
🟦 RunTask(nx-compat:build) 1.3s Cached
🟩 RunTask(nx-compat:format) 1.8s Passed
🟩 RunTask(website:format) 10.2s Passed
🟦 RunTask(website:build) 22.8s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 22
Touched files
CHANGELOG.md
crates/config/src/workspace/hasher_config.rs
crates/config/tests/workspace_config_test.rs
crates/process/src/command.rs
crates/process/src/command_line.rs
crates/process/src/exec_command.rs
crates/task-hasher/src/task_hasher.rs
crates/vcs/src/git.rs
crates/vcs/src/vcs.rs
crates/vcs/tests/git_test.rs
crates/workspace/src/workspace_builder.rs
website/docs/config/workspace.mdx

Copy link

Run report for 7e80eae4 (windows-latest, 20)

Total time: 2m 13s | Comparison time: 5m 11s | Estimated savings: 2m 58s (57.2% faster)

Action Time Status Info
🟩 SyncWorkspace 204.4ms Passed
🟩 SetupToolchain(node:~20) 44.5s Passed
🟩 SyncProject(node, types) 8.5ms Passed
🟩 SyncProject(node, runtime) 6.2ms Passed
🟩 SyncProject(node, report) 8ms Passed
🟩 SyncProject(node, nx-compat) 9.6ms Passed
🟩 SyncProject(node, website) 6.6ms Passed
🟩 InstallWorkspaceDeps(node:~20) 1m 9s Passed
🟦 RunTask(types:build) 1.4s Cached
🟦 RunTask(runtime:test) 163ms Cached
🟦 RunTask(runtime:typecheck) 169.3ms Cached
🟦 RunTask(report:test) 295.7ms Cached
🟦 RunTask(runtime:lint) 144.5ms Cached
🟦 RunTask(runtime:build) 383.4ms Cached
🟦 RunTask(report:lint) 151.5ms Cached
🟦 RunTask(nx-compat:test) 184.7ms Cached
🟦 RunTask(nx-compat:typecheck) 154.3ms Cached
🟦 RunTask(nx-compat:lint) 139.9ms Cached
🟦 RunTask(report:build) 656.7ms Cached
🟦 RunTask(report:typecheck) 138.9ms Cached
And 9 more...
Expanded report
Action Time Status Info
🟩 RunTask(runtime:format) 1.5s Passed
🟦 RunTask(website:typecheck) 239.8ms Cached
🟦 RunTask(nx-compat:build) 1s Cached
🟦 RunTask(website:test) 275.1ms Cached
🟩 RunTask(report:format) 1.8s Passed
🟦 RunTask(website:lint) 224ms Cached
🟩 RunTask(nx-compat:format) 1.9s Passed
🟩 RunTask(website:format) 10.7s Passed
🟦 RunTask(website:build) 15.9s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20
Touched files
CHANGELOG.md
crates/config/src/workspace/hasher_config.rs
crates/config/tests/workspace_config_test.rs
crates/process/src/command.rs
crates/process/src/command_line.rs
crates/process/src/exec_command.rs
crates/task-hasher/src/task_hasher.rs
crates/vcs/src/git.rs
crates/vcs/src/vcs.rs
crates/vcs/tests/git_test.rs
crates/workspace/src/workspace_builder.rs
website/docs/config/workspace.mdx

@milesj milesj merged commit cf10118 into develop-1.33 Mar 11, 2025
20 checks passed
@milesj milesj deleted the 1.33-hash-bytes branch March 11, 2025 01:58
milesj added a commit that referenced this pull request Mar 13, 2025
* Rework batching.

* Add continuous exec.

* Improve logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant