Fix evm tracing for native ERC20 foreign asset registrations #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
changed the title
RomarQ
changed the title
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (no changes) 🚨 Moonbeam runtime: 2400 KB (no changes) ✅ Moonriver runtime: 2400 KB (no changes) ✅ Compared to latest release (runtime-3501)Moonbase runtime: 2420 KB (+468 KB compared to latest release) 🚨 Moonbeam runtime: 2400 KB (+460 KB compared to latest release) Moonriver runtime: 2400 KB (+460 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/fix-evm-tracing +/- ##
======================================================
- Coverage 74.48% 74.47% -0.01%
Files 380 380
+ Lines 96174 96179 +5
======================================================
- Hits 71626 71624 -2
+ Misses 24548 24555 +7
|
RomarQ
added
A10-evmtracing
TarekkMA
reviewed
Feb 19, 2025
TarekkMA
previously approved these changes
Feb 19, 2025
TarekkMA
approved these changes
Feb 19, 2025
pLabarta
reviewed
Feb 19, 2025
stiiifff
approved these changes
Feb 19, 2025
4 tasks
RomarQ
added a commit
to moonbeam-foundation/moonbeam-runtime-overrides
that referenced
this pull request
Feb 20, 2025
…, 3501] (#123) * apply patch to runtimes 3400, 3401, 3500 and 3501 * patch runtime 3500 wasm * patch runtime 3400 wasm * patch runtime 3401 wasm * patch runtime 3501 wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Handle tracing of evm transactions triggered inside
force_transact_ascall of pallet ethereum-xcm.In July we added a new call (force_transact_as) to the pallet ethereum_xcm, which calls the EvmRunner internally. When calling the pallet ethereum-xcm, we must be sure that the
ETHEREUM_XCM_TRACING_STORAGE_KEYis set when the tracing is enabled, which was not the case for the callforce_transact_asused to register the new asset.