-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add article for moralis #951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great starting point! I've added some suggestions for changes to bring this in line with the style guide and help it match our existing similar sections more closely. Many of these suggestions are small punctuation changes, so don't let the number of comments alarm you!
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Hi @dawnkelly09 Thank you for reviewing the article. Appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies. I misunderstood what the style guide says about colons vs. dashes in lists, which is why I suggested those changes. I've switched them back, which is all that has changed in this review. Thank you for your patience while I am learning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updates applied. lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to review this before it gets merged, so just marking it as changes requested for right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this!
Some general comments:
- All of the images should have the browser window in them
- Use steps when you can to break up the content and provide clear instructions
- Read through the section headers to make sure they all flow and are consistent
- Add explanations so the sections aren't just like you can do this and that, without explanation or elaborating on what else can be done or where to find more info
Edit the images Added missing {target=\_blank} elements for URLs refactors wording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there!
Co-authored-by: Erin Shaben <[email protected]>
β¦ndation/moonbeam-docs into Add_article_moralis
Co-authored-by: Erin Shaben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images still need some work, the browser window should not be orange, it should be a dark color, like the rest of the images on the docs site. I'm sorry, I know this is probably frustrating. I'm going to go through today to make the style guide super explicit on what to do and not to do so that it's more clear moving forward.
Co-authored-by: Erin Shaben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just found a couple things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good! The images look great! Just a couple things though:
- The arrows in these images aren't the ones that are shown in the style guide. Can you please update it?
- Can you please also confirm that the size of the circles for the steps are 24x24px?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed up with you about the images in slack
@themacexpert any remaining comments or all good from your side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
Co-authored-by: Kevin Neilson <[email protected]>
f8477fd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adding an article for Moralis
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiramoonbeam-mkdocs
to update redirectsmove-pages.py
script to move the pages and update the image paths on the chinese repomoonbeam-docs-cn
compress-images.py
script to compress the images.moonbeam-docs-cn
repo to use the new variablesCorresponding PRs
Please link to any corresponding PRs here.
After Translation Requirements
moonbeam-docs
repo to remove imagesmoonbeam-docs
repo to remove variablesmoonbeam-mkdocs
repo to add redirects for Chinese siteItems to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.