Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve error handling and fix wrong compress dir for windows #368

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

moonD4rk
Copy link
Owner

@moonD4rk moonD4rk commented Jul 17, 2024

  • fix: Improve error handling and fix wrong compress dir for windows
  • refactor: Refactor fileutil package for pass linter

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit, build tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

)

* fix: Improve error handling and fix wrong compress dir for windows
* refactor: Refactor fileutil package for pass linter

- Refactored the `CompressDir` function in the `fileutil` package for improved error handling and handling of edge cases
- Improved error messages for various file operations
- Added test file and created tests for the `CompressDir` function in the `fileutil` package
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9976135863

Details

  • 29 of 42 (69.05%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.6%) to 18.666%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/hack-browser-data/main.go 0 1 0.0%
utils/fileutil/filetutil.go 29 41 70.73%
Files with Coverage Reduction New Missed Lines %
utils/fileutil/filetutil.go 1 33.33%
Totals Coverage Status
Change from base Build 9950517049: 1.6%
Covered Lines: 375
Relevant Lines: 2009

💛 - Coveralls

@moonD4rk moonD4rk merged commit 271e052 into main Jul 17, 2024
8 checks passed
@moonD4rk moonD4rk deleted the dev branch July 17, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants