[python-pytrakt] Privacy: Don't log headers to protect privacy #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe add a switch in config which is deactivated by default. It is sometimes useful to the user when working with multiple instances to check for cross-contamination of config. |
|
this project doesn't support instances, at least not in v3 |
|
Here's are more examples where user shared their tokens just because they didn't know: |
2 tasks
glensc
added a commit
to glensc/python-pytrakt
that referenced
this pull request
Oct 24, 2022
|
Carried to my fork: |
This was referenced Oct 24, 2022
glensc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario, where need to really debug HTTP headers, are perhaps when developing this library. This is never useful for end-users and could cause leaking the tokens when sharing logs:
refs: