Solving PHP 7.2 deprecation of create_function.

difflib.php

@@ -304,8 +304,9 @@ public function __construct($data, $linepos) {
         $data = str_replace(array(' ', ' ', ' ') , '      ', $data);
 
         // Tags replaced with equal number of spaces
-        $data = preg_replace_callback('/<.*?'.'>/', create_function(
-            '$matches', 'return preg_replace("/./"," ", $matches[0]);'), $data);
+        $data = preg_replace_callback('/<.*?'.'>/', function($matches) {
+            return preg_replace("/./"," ", $matches[0]);
+        }, $data);
 
         // 2. Analyse string so that each space-separated thing
         // is counted as a 'word' (note these may not be real words,
@@ -409,8 +410,9 @@ function ouwiki_diff_html_to_lines($content) {
     // Get rid of all script, style, object tags (that might contain non-text
     // outside tags)
     $content = preg_replace_callback(
-        '^(<script .*?</script>)|(<object .*?</object>)|(<style .*?</style>)^i', create_function(
-            '$matches', 'return preg_replace("/./"," ",$matches[0]);'), $content);
+            '^(<script .*?</script>)|(<object .*?</object>)|(<style .*?</style>)^i', function($matches) {
+                return preg_replace("/./"," ",$matches[0]);
+            }, $content);
 
     // Get rid of all ` symbols as we are going to use these for a marker later.
     $content = preg_replace('/[`]/', ' ', $content);
@@ -424,8 +426,9 @@ function ouwiki_diff_html_to_lines($content) {
         }
         $taglist .= "<$blocktag>|<\\/$blocktag>";
     }
-    $content = preg_replace_callback('/(('.$taglist.')\s*)+/i', create_function(
-        '$matches', 'return "`".preg_replace("/./"," ",substr($matches[0],1));'), $content);
+    $content = preg_replace_callback('/(('.$taglist.')\s*)+/i', function($matches) {
+        return "`".preg_replace("/./"," ",substr($matches[0],1));
+    }, $content);
 
     // Now go through splitting each line
     $lines = array();
@@ -697,7 +700,9 @@ function ouwiki_diff($file1, $file2) {
  */
 function ouwiki_diff_add_markers($html, $words, $markerclass, $beforetext, $aftertext) {
     // Sort words by start position
-    usort($words, create_function('$a,$b', 'return $a->start-$b->start;'));
+    usort($words, function($a, $b) {
+        return $a->start-$b->start;
+    });
 
     // Add marker for each word. We use an odd tag name which will
     // be replaced by span later, this for ease of replacing

locallib.php

@@ -584,7 +584,9 @@ function ouwiki_display_subwiki_selector($subwiki, $ouwiki, $cm, $context, $cour
     switch($ouwiki->subwikis) {
         case OUWIKI_SUBWIKIS_GROUPS:
             $groups = groups_get_activity_allowed_groups($cm);
-            uasort($groups, create_function('$a,$b', 'return strcasecmp($a->name,$b->name);'));
+            uasort($groups, function($a, $b) {
+                return strcasecmp($a->name,$b->name);
+            });
             $wikifor = htmlspecialchars($groups[$subwiki->groupid]->name);
 
             // Do they have more than one?