Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TMP permissions to avoid UPLOAD_ERR_NO_TMP_DIR. #4

Conversation

scara
Copy link
Contributor

@scara scara commented Jun 28, 2017

Related issues: moodlehq/moodle-docker#9.

Related issues: danpoltawski/docker-moodle/moodlehq#9.
@danpoltawski
Copy link
Contributor

Ahh, this seemed extremely weird to me that it would be present in the upstream php image..

So then I realised it's probably actually because of the above ADD command..

And the problem being the permissions set on the folder here: https://github.com/danpoltawski/moodle-php-apache/tree/master/root/tmp

So would be setting those permissions be a better fix?

@danpoltawski
Copy link
Contributor

Ah but of course git can't track those permissions!

@danpoltawski danpoltawski merged commit 3765950 into moodlehq:master Jul 5, 2017
@scara
Copy link
Contributor Author

scara commented Jul 5, 2017

Another proposal, that I didn't make to preserve your initial hierarchy, is to use e.g. /opt and not /tmp but I think it would be better to do it when working at #1 where even /opt could be not a good choice (I still think it will be 😉 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants