Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to use PHP 8.3 #298

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented May 20, 2024

Only the compare_databases need some tricks because we still have only 4.4.0 tag and 404 and main branches supporting php83. As soon as we have more branches supporting that php version, we'll amend the tests.

@stronk7 stronk7 force-pushed the move_tests_to_php83 branch 2 times, most recently from c8a059a to 3c9fae2 Compare May 20, 2024 17:15
Only the compare_databases need some tricks because
we still have only 4.4.0 tag and 404 and main branches
supporting php83. As soon as we have more branches
supporting that php version, we'll amend the tests.
@stronk7 stronk7 force-pushed the move_tests_to_php83 branch from 3c9fae2 to db73352 Compare May 20, 2024 21:06
@stronk7
Copy link
Member Author

stronk7 commented May 21, 2024

I'm self-merging this because want to start working with #296, that will introduce more changes to the tests...

@stronk7 stronk7 merged commit 3490e2d into moodlehq:main May 21, 2024
4 checks passed
@stronk7 stronk7 deleted the move_tests_to_php83 branch May 21, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant