Fall back to ionic7 app runtime #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, it seems that we need to do something, in GHA tests, with old branches? (311 and 400) to keep them working with ionic 5? Or just remove them? |
Older versions of the LMS won't work with the app because they need the patch introduced in MDL-80784
|
@stronk7 It should work now, I decided to keep them running against old versions to make sure that the ionic5 runtime still works in case someone needs it. But eventually we could remove it as well because none of the current versions of the app (stable, development) use it anymore. |
|
Thanks, @NoelDeMartin, looks ok. I'll wait for all tests to finish (they are looking perfect) and will merge this then (1h aprox). Ciao :-) |
|
Ok, there was a PHPUnit failure (random) and I've relaunched the job. No matter of that, I'm going to merge this now, so it's available for the masses. Ciao :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've released 4.4.0 version of the app, so
ionic7can now be used as the default runtime.