[docs] max sections deprecation #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranrecio
added
the
blocked-by-tracker
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sarjona
requested changes
Jun 2, 2025
There was a problem hiding this comment.
Hi @ferranrecio!
Thanks for working on this. The changes look good, but I missed:
- Marking as deprecated references to get_max_sections() method in https://moodledev.io/docs/apis/plugintypes/format#course-sections
- A basic example or a reference to the weekly format to make it easier to third-party developers to see how this can be done.
sarjona
added
waiting-for-feedback
and removed
blocked-by-tracker
ferranrecio
force-pushed
the
MDL-84291-main
branch
from
32d65fc to
7d504de
Compare
|
Hi @sarjona , I changed some of the text to include all the information. Regarding get_max_sections, I removed the method from plugintype/format in the current version. |
sarjona
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Hi @ferranrecio!
Thanks for documenting this change and improving it :-)
I'm happy to approve it and I'll merge it once weeklies are rolled ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.