Make codechecker happy again

classes/privacy/provider.php

@@ -39,7 +39,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

lang/en/block_people.php

@@ -24,39 +24,35 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$string['pluginname'] = 'People';
+$string['noparticipantslist'] = 'Viewing the participants list is prohibited in this course';
 $string['participantslist'] = 'Show participants list';
 $string['people:addinstance'] = 'Add a new people block';
 $string['people:myaddinstance'] = 'Add a new people block to Dashboard';
+$string['pluginname'] = 'People';
 $string['privacy:metadata'] = 'The people plugin provides extended functionality to Moodle users, but does not store any personal data.';
-$string['noparticipantslist'] = 'Viewing the participants list is prohibited in this course';
-
-// Settings.
-$string['setting_participantspageheading'] = 'Participants page';
-$string['setting_linkparticipantspage'] = 'Show link to the participants page';
-$string['setting_linkparticipantspage_desc'] = 'By enabling this setting, a link to the participants page of the course will be shown within the block.';
-$string['setting_hideblockheading'] = 'Hiding the block';
+$string['resetvisibilityerror'] = 'Oops... Something went wrong updating the database tables... <br/> The setting "Reset visibility" has been reset.';
+$string['resetvisibilitysuccess'] = 'Success! All "block_people" instances are visible (again). <br/> The setting "Reset visibility" has been reset.';
 $string['setting_hideblock'] = 'Hiding the block';
 $string['setting_hideblock_desc'] = 'By enabling this setting, the block can be hidden by users.<br/>
 Important notice:<br/>
 Disabling this setting will entirely remove the showing / hiding the block menu item. This means, that users cannot hide this block anymore, but on the other hand, blocks that are already hidden cannot be shown anymore, too. If you want to enable this feature, consider using the following function to reset the visibility for all "block_people" instances.';
-$string['setting_linkingheading'] = 'Linking';
+$string['setting_hideblockheading'] = 'Hiding the block';
 $string['setting_linkavatar'] = 'Link avatar';
 $string['setting_linkavatar_desc'] = 'By enabling this setting, a link to the teacher\'s user page will be added onto the teacher\'s avatar. The link will only be added if the user is allowed to view user profiles.';
-$string['setting_linkname'] = 'Link name';
-$string['setting_linkname_desc'] = 'By enabling this setting, a link to the teacher\'s user page will be added onto the teacher\'s name. The link will only be added if the user is allowed to view user profiles.';
+$string['setting_linkingheading'] = 'Linking';
 $string['setting_linkmessaging'] = 'Link to messaging';
 $string['setting_linkmessaging_desc'] = 'By enabling this setting, a link to the teacher\'s messaging page will be added below the teacher\'s name. The link will only be added if the user is allowed to message the teacher.';
+$string['setting_linkname'] = 'Link name';
+$string['setting_linkname_desc'] = 'By enabling this setting, a link to the teacher\'s user page will be added onto the teacher\'s name. The link will only be added if the user is allowed to view user profiles.';
+$string['setting_linkparticipantspage'] = 'Show link to the participants page';
+$string['setting_linkparticipantspage_desc'] = 'By enabling this setting, a link to the participants page of the course will be shown within the block.';
 $string['setting_multipleroles'] = 'Show multiple roles';
 $string['setting_multipleroles_desc'] = 'This setting allows you to control if users who have more than one of the roles configured above are listed once or multiple times in this block. If this setting is disabled, users will be only listed with the first role they have according to the global role sort order. If this setting is enabled, users will be listed within each of their roles.';
+$string['setting_participantspageheading'] = 'Participants page';
 $string['setting_resetvisibility'] = 'Reset visibility';
 $string['setting_resetvisibility_desc'] = 'By enabling this checkbox, the visibility of all existing "block_people" instances will be set to visible (again).<br/>
 Please note: <br/>
 After saving this option, the database operations for resetting the visibility will be triggered and this checkbox will be unticked again. The next enabling and saving of this feature will trigger the database operations for resetting the visibility again. ';
-$string['setting_rolesheading'] = 'Roles';
 $string['setting_roles'] = 'Show these roles';
 $string['setting_roles_desc'] = 'This setting allows you to control which users appear in this block. Users need to have at least one of these roles in a course to be shown in the block.';
-
-// Notifications.
-$string['resetvisibilitysuccess'] = 'Success! All "block_people" instances are visible (again). <br/> The setting "Reset visibility" has been reset.';
-$string['resetvisibilityerror'] = 'Oops... Something went wrong updating the database tables... <br/> The setting "Reset visibility" has been reset.';
+$string['setting_rolesheading'] = 'Roles';