Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some plugins #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added some plugins #11

wants to merge 4 commits into from

Conversation

marcosfede
Copy link

Hello there :)
I started adding some plugins to ePIT.
There is no need for you to merge these changes, I'm just submitting these so I can get some feedback from you about which scripts should be included in the installer.
Uninstallation and installation status for most scripts still needs to be worked on, some of them may not work.
I'll try to add some more scripts this week.
Cheers

@monsieurh
Copy link
Owner

monsieurh commented Mar 18, 2017

Impressive, thank you for taking the time to write all these scripts!

I especially like that you put all the programming stuff in, well, the 'programming' category. I fear that it will grow endlessly though. I'd rather focus on end-user experience. I suppose most programmer won't mind the trouble of typing 'apt-get' anyway. So I don't know if we should go down that road at the moment.

Aside from that, it seems OK for me. Could you add a new line at the end of files though?

Also elementary tweaks and archive format plugins already exist, you could merge them with yours instead.
Finally, about the bittorent client I think we should favor something closer to the native elementary look. Again, focusing on end user experience, Qt seems out of place in the middle of pantheon apps.

@@ -8,10 +8,11 @@ fi
echo "Installing updates..."
apt update -y
apt install -y git gjs

apt install -y ppa-purge
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you develop on why it is needed when installing the app itself?

@mvaldes14
Copy link

mvaldes14 commented Mar 19, 2017

These are great but i believe like stated before, somewhere on the installer you should be able to select some of the bundles, like programming, not everyone might use the software in there and as we know.... laptops have limited hard drive space, worse for people who are dual booting.

besides that, these are the must-have programming pieces i have on my system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants