Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs/README): syntax for editor_toolbar_buttons has to be with double brackets #250

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

mathieu-coingt
Copy link
Contributor

@mathieu-coingt mathieu-coingt commented Nov 5, 2024

Sample configuration is currently wrong.
In the form type, you need to define configuration for editor_toolbar_buttons with double brackets.

Before :

$builder->add('myField', WysiwygType::class, [
...
'editor_toolbar_buttons' => ['bold', 'italic', 'underline', ...]
])

After :

$builder->add('myField', WysiwygType::class, [
...
'editor_toolbar_buttons' => [['bold', 'italic', 'underline', ...]]
])

@madamebiz madamebiz added the quick win Easy to pick, everybody will be happy. label Nov 5, 2024
@maximehuran maximehuran requested a review from lanfisis January 21, 2025 10:33
@madamebiz madamebiz added the Status: needs review Status: needs review label Jan 21, 2025
@maximehuran maximehuran merged commit 3eba73a into monsieurbiz:master Jan 21, 2025
@maximehuran
Copy link
Member

Thank you @mathieu-coingt 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick win Easy to pick, everybody will be happy. Status: needs review Status: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants