-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage multiple coupons in order #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delyriand
requested changes
Dec 19, 2023
src/Promotion/Decorator/OrderPromotionsUsageModifierDecorator.php
Outdated
Show resolved
Hide resolved
src/Promotion/Decorator/PromotionSubjectCouponEligibilityCheckerDecorator.php
Outdated
Show resolved
Hide resolved
madamebiz
added
Status: needs update
This Issue/PR needs update
and removed
Status: needs review
Needs review
labels
Dec 19, 2023
madamebiz
added
Status: needs review
Needs review
and removed
Status: needs update
This Issue/PR needs update
labels
Dec 19, 2023
lanfisis
approved these changes
Dec 19, 2023
Kiwikoti
approved these changes
Dec 19, 2023
delyriand
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple Coupons
Demo in cart
In my example I have :
FLASH_SALES
couponGIFT_CARD
coupon (Applied after tax)Enregistrement.de.l.ecran.2023-12-18.a.15.49.34.mov
Increment / Decrement
When an order is complete, the coupon usage is incremented
When an order is canceled, the coupon usage is decremented