Few improvements

monsieurbiz · Dec 19, 2023 · d10e37b · d10e37b
1 parent 330a0b1
commit d10e37b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/Entity/PromotionCouponsAwareTrait.php b/src/Entity/PromotionCouponsAwareTrait.php
@@ -46,13 +46,7 @@ public function getPromotionCoupons(): Collection
 
     public function hasPromotionCoupon(PromotionCouponInterface $promotionCoupon): bool
     {
-        foreach ($this->promotionCoupons as $currentPromotionCoupon) {
-            if ($currentPromotionCoupon === $promotionCoupon) {
-                return true;
-            }
-        }
-
-        return false;
+        return $this->promotionCoupons->contains($promotionCoupon);
     }
 
     public function addPromotionCoupon(PromotionCouponInterface $promotionCoupon): void

diff --git a/src/Form/Extension/CartTypeExtension.php b/src/Form/Extension/CartTypeExtension.php
@@ -66,8 +66,8 @@ public function validatePromotionEntry(?PromotionCouponInterface $entry, Executi
         }
 
         $context
-                ->buildViolation('sylius.promotion_coupon.is_invalid')
-                ->addViolation()
+            ->buildViolation('sylius.promotion_coupon.is_invalid')
+            ->addViolation()
         ;
     }