Don't move local objects to ease copy elision

monocasual · Mar 7, 2019 · 0d8f174 · 0d8f174
1 parent 48f506c
commit 0d8f174
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/core/pluginManager.cpp b/src/core/pluginManager.cpp
@@ -220,7 +220,7 @@ std::unique_ptr<Plugin> makePlugin(const string& fid)
 	}
 	gu_log("[pluginManager::makePlugin] plugin instance with fid=%s created\n", fid.c_str());
 
-	return std::move(std::make_unique<Plugin>(pi, samplerate_, buffersize_));
+	return std::make_unique<Plugin>(pi, samplerate_, buffersize_);
 }
 
 
@@ -252,7 +252,7 @@ std::unique_ptr<Plugin> makePlugin(const Plugin& src)
 	for (int i=0; i<src.getNumParameters(); i++)
 		p->setParameter(i, src.getParameter(i));	
 
-	return std::move(p);
+	return p;
 }
 
 

diff --git a/src/core/waveManager.cpp b/src/core/waveManager.cpp
@@ -123,7 +123,7 @@ std::unique_ptr<Wave> createEmpty(int frames, int channels, int samplerate,
 	gu_log("[waveManager::createEmpty] new empty Wave created, %d frames\n", 
 		wave->getSize());
 
-	return std::move(wave);
+	return wave;
 }
 
 
@@ -142,7 +142,7 @@ std::unique_ptr<Wave> createFromWave(const Wave* src, int a, int b)
 
 	gu_log("[waveManager::createFromWave] new Wave created, %d frames\n", frames);
 
-	return std::move(wave);
+	return wave;
 }