Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed object translation not working properly when passing lng options #889

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fixed object translation not working properly when passing lng options #889

merged 1 commit into from
Nov 22, 2024

Conversation

dlymonkai
Copy link
Contributor

@dlymonkai dlymonkai commented Nov 22, 2024 •
edited
Loading

Overview

Jira Ticket Reference : MN-666

Checklist before requesting a review

  • I have updated the unit tests based on the changes I made
  • I have updated the docs (TSDoc / README / global doc) to reflect my changes
  • I have updated the local app configs if needed
  • I have performed self-QA of my feature by testing the apps and packages and made sure that :
    • No regression or new bug has occurred
    • The acceptance criteria listed in the ticket are met
    • Self-QA was made on both desktop and mobile

@dlymonkai dlymonkai merged commit 72e99d5 into main Nov 22, 2024
3 checks passed
@dlymonkai dlymonkai deleted the fix/MN-666/obj-translation branch November 22, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souyahia-monk souyahia-monk Awaiting requested review from souyahia-monk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dlymonkai