Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with getAllInspections requests #886

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

souyahia-monk
Copy link
Contributor

@souyahia-monk souyahia-monk commented Nov 22, 2024

Overview

Jira Ticket Reference : MN-663

Fix issues with getAllInspections requests :

  • Fixed wrong exports for certain request types
  • Renamed getInspections and getInspectionsCount to getAllInspections and getAllInspectionsCount
  • Added pagination to the request return type
  • Fixed wrong Api types (not properly mapped from swagger)
  • Filter out verbose from the user-passed URL filters
  • Added missing tests

Checklist before requesting a review

  • I have updated the unit tests based on the changes I made
  • I have updated the docs (TSDoc / README / global doc) to reflect my changes
  • I have updated the local app configs if needed
  • I have performed self-QA of my feature by testing the apps and packages and made sure that :
    • No regression or new bug has occurred
    • The acceptance criteria listed in the ticket are met
    • Self-QA was made on both desktop and mobile

@souyahia-monk souyahia-monk changed the title Feat/mn 663/total items pagination tesla Fix issues with getAllInspections requests Nov 22, 2024
@souyahia-monk souyahia-monk force-pushed the feat/MN-663/total-items-pagination-tesla branch from 8cca677 to c3ea5d0 Compare November 22, 2024 09:16
@souyahia-monk souyahia-monk force-pushed the feat/MN-663/total-items-pagination-tesla branch from c3ea5d0 to b1b1815 Compare November 22, 2024 09:18
@souyahia-monk souyahia-monk merged commit 655d51d into main Nov 22, 2024
3 checks passed
@souyahia-monk souyahia-monk deleted the feat/MN-663/total-items-pagination-tesla branch November 22, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant