Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up NPM deploy errors #820

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Clean up NPM deploy errors #820

merged 2 commits into from
Aug 2, 2024

Conversation

souyahia-monk
Copy link
Contributor

@souyahia-monk souyahia-monk commented Aug 2, 2024 •
edited
Loading

Overview

Jira Ticket Reference : MN-592

Fixed some issues after first NPM deployment

Checklist before requesting a review

  • I have updated the unit tests based on the changes I made
  • I have updated the docs (TSDoc / README / global doc) to reflect my changes
  • I have updated the local app configs if needed
  • I have performed self-QA of my feature by testing the apps and packages and made sure that :
    • No regression or new bug has occurred
    • The acceptance criteria listed in the ticket are met
    • Self-QA was made on both desktop and mobile

@souyahia-monk souyahia-monk force-pushed the feat/MN-592/clean-up-npm-deploy branch from a8989ce to c036698 Compare August 2, 2024 08:29
@souyahia-monk souyahia-monk merged commit d0d6517 into main Aug 2, 2024
4 checks passed
@souyahia-monk souyahia-monk deleted the feat/MN-592/clean-up-npm-deploy branch August 2, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@souyahia-monk