Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added additional config validator for thumbnail domain + fetch thumbnail when addImage #813

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Added additional config validator for thumbnail domain + fetch thumbnail when addImage #813

merged 5 commits into from
Jul 26, 2024

Conversation

dlymonkai
Copy link
Contributor

@dlymonkai dlymonkai commented Jul 17, 2024 •
edited
Loading

Overview

Checklist before requesting a review

  • I have updated the unit tests based on the changes I made
  • I have updated the docs (TSDoc / README / global doc) to reflect my changes
  • I have performed self-QA of my feature by testing the apps and packages and made sure that :
    • No regression or new bug has occurred
    • The acceptance criteria listed in the ticket are met
    • Self-QA was made on both desktop and mobile

@dlymonkai dlymonkai force-pushed the fix/thumbnail-validator branch from 4d1816a to 2c57566 Compare July 17, 2024 14:27
@dlymonkai dlymonkai force-pushed the fix/thumbnail-validator branch 2 times, most recently from c4a0c9c to 84d50b8 Compare July 18, 2024 14:16
@dlymonkai dlymonkai changed the title Added additional config validator for thumbnail domain Added additional config validator for thumbnail domain + fetch thumbnail when addImage Jul 22, 2024
@dlymonkai dlymonkai force-pushed the fix/thumbnail-validator branch 8 times, most recently from 3c0f510 to 4e3295d Compare July 23, 2024 14:53
souyahia-monk
souyahia-monk requested changes Jul 24, 2024
View reviewed changes
documentation/src/utils/schemas.ts Outdated Show resolved Hide resolved
packages/network/src/api/image/requests.ts Outdated Show resolved Hide resolved
packages/network/src/api/image/requests.ts Outdated Show resolved Hide resolved
packages/network/src/api/image/requests.ts Outdated Show resolved Hide resolved
packages/network/src/api/image/requests.ts Outdated Show resolved Hide resolved
packages/network/src/api/utils.ts Outdated Show resolved Hide resolved
packages/network/src/api/utils.ts Outdated Show resolved Hide resolved
@dlymonkai dlymonkai force-pushed the fix/thumbnail-validator branch 5 times, most recently from 35f876d to 8d94ab1 Compare July 25, 2024 10:10
@dlymonkai dlymonkai force-pushed the fix/thumbnail-validator branch from 8d94ab1 to fc8c063 Compare July 25, 2024 15:27
@dlymonkai dlymonkai force-pushed the fix/thumbnail-validator branch from fc8c063 to 0d5e6b8 Compare July 26, 2024 08:45
@dlymonkai dlymonkai merged commit 99e1e97 into main Jul 26, 2024
4 checks passed
@dlymonkai dlymonkai deleted the fix/thumbnail-validator branch July 26, 2024 09:11
@sentry-io Sentry.io
Copy link

sentry-io bot commented Jul 30, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'endsWith') exports.exports(packages/network/src/api/utils) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souyahia-monk souyahia-monk souyahia-monk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlymonkai @souyahia-monk