Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sight out of the camera #808

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fixed sight out of the camera #808

merged 1 commit into from
Jul 10, 2024

Conversation

dlymonkai
Copy link
Contributor

@dlymonkai dlymonkai commented Jul 10, 2024 •
edited by jira bot
Loading

Overview

Jira Ticket Reference : MN-577

Fixed sight width and height style not passed to the SVG props.

Checklist before requesting a review

  • I have updated the unit tests based on the changes I made
  • I have updated the docs (TSDoc / README / global doc) to reflect my changes
  • I have performed self-QA of my feature by testing the apps and packages and made sure that :
    • No regression or new bug has occurred
    • The acceptance criteria listed in the ticket are met
    • Self-QA was made on both desktop and mobile

@dlymonkai dlymonkai merged commit 100d8f5 into main Jul 10, 2024
4 checks passed
@dlymonkai dlymonkai deleted the fix/MN-577/sights-out-of-camera branch July 10, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dlymonkai