Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Validate button on the gallery #789

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

dlymonkai
Copy link
Contributor

@dlymonkai dlymonkai commented Jun 14, 2024

Overview

Jira Ticket Reference : MN-561

Optional validateButtonLabel can be passed to Photocapture to display custom validate button label.

Checklist before requesting a review

  • I have updated the unit tests based on the changes I made
  • I have updated the docs (TSDoc / README / global doc) to reflect my changes
  • I have performed self-QA of my feature by testing the apps and packages and made sure that :
    • No regression or new bug has occurred
    • The acceptance criteria listed in the ticket are met
    • Self-QA was made on both desktop and mobile

@dlymonkai dlymonkai force-pushed the feat/MN-561/rename-validate-btn-gallery branch 2 times, most recently from 4d24de4 to 1263882 Compare June 19, 2024 10:02
@dlymonkai dlymonkai force-pushed the feat/MN-561/rename-validate-btn-gallery branch from 1263882 to d233de0 Compare June 19, 2024 12:11
@dlymonkai dlymonkai merged commit 23fa26a into main Jun 19, 2024
4 checks passed
@dlymonkai dlymonkai deleted the feat/MN-561/rename-validate-btn-gallery branch June 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants