👌 some types and extras

monkvision · Jul 17, 2024 · e95f7c8 · e95f7c8
1 parent b9537e8
commit e95f7c8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/packages/common/README/HOOKS.md b/packages/common/README/HOOKS.md
@@ -152,8 +152,6 @@ function MyComponent() {
 
 This hook is used to prevent the user from leaving the page by displaying a confirmation dialog when the user tries to
 leave the page.
-usePreventExit expects a boolean value generally a expression.
-allowRedirect - usePreventExit can be used multiple places. This act as a temporary override to allow to navigate.
 
 ### useQueue
 ```tsx

diff --git a/packages/common/src/PreventExit/hooks.ts b/packages/common/src/PreventExit/hooks.ts
@@ -1,5 +1,6 @@
 import { useEffect, useMemo } from 'react';
 import { PreventExitListenerResult, createPreventExitListener } from './store';
+import { useObjectMemo } from '../hooks';
 
 /**
  * Custom hook that allows preventing the user from exiting the page or navigating away.
@@ -20,5 +21,5 @@ export function usePreventExit(
   const { cleanup, setPreventExit, allowRedirect } = useMemo(createPreventExitListener, []);
   useEffect(() => setPreventExit(preventExit), [preventExit]);
   useEffect(() => cleanup, []);
-  return { allowRedirect };
+  return useObjectMemo({ allowRedirect });
 }
diff --git a/packages/common/src/PreventExit/store.ts b/packages/common/src/PreventExit/store.ts
@@ -10,7 +10,7 @@ function arePreventExitRemaining() {
   return false;
 }
 
-function publish(id: symbol, preventExit: boolean) {
+function publish(id: symbol, preventExit: boolean): void {
   allPreventExitState[id] = preventExit;
   if (!arePreventExitRemaining())
     window.onbeforeunload = (e) => {