mg_rpc_check_nonce smaller time drift tolerance #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd suggest that providing an hour in the past is too long. Even with global traversing MQTT and processing delays it should handle a response well within 2 minutes. NTP docs suggest a device without NTP sync will drift about 8 seconds a day. 2 minutes provides a full week without sync. I've provided a method that doesn't presume this device is accurate, the client who offered an initial nonce before the challenge may actually have the correct time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd suggest that providing an hour in the past is too long. Even with global traversing MQTT and processing delays it should handle a response well within 2 minutes.
NTP docs suggest a device without NTP sync will drift about 8 seconds a day. 2 minutes provides a full week without sync.
I've provided a method that doesn't presume this device is accurate, the client who offered an initial nonce before the challenge may actually have the correct time.