MONGOID-5829 Add a way to ignore paths for model loading #5904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us exclude the `/concerns/` subdirectory that Rails promotes. Loading the concerns explicitly leads to load errors when the concerns reference a model that hasn't been loaded yet.
comandeo-mongo
approved these changes
Nov 20, 2024
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Nov 20, 2024
This lets us exclude the `/concerns/` subdirectory that Rails promotes. Loading the concerns explicitly leads to load errors when the concerns reference a model that hasn't been loaded yet.
jamis
added a commit
that referenced
this pull request
Nov 20, 2024
This lets us exclude the `/concerns/` subdirectory that Rails promotes. Loading the concerns explicitly leads to load errors when the concerns reference a model that hasn't been loaded yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
Mongoid.load_models, it will blindly try to load all Ruby files in the model load path. This can fail when the loader tries to load files (like concerns) that do not define models, but which reference models that have not yet been loaded.This PR attempts to address this by adding a new
ignore_patternsoption, which defaults to an array with a single string,*/concerns/*. Any path that matches this pattern will be ignored by the loader.