-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MONGOID-5601 Atlas Search Index Management #5723
Merged
jamis
merged 13 commits into
mongodb:master
from
jamis:5601-atlas-search-index-management
Sep 27, 2023
Merged
MONGOID-5601 Atlas Search Index Management #5723
jamis
merged 13 commits into
mongodb:master
from
jamis:5601-atlas-search-index-management
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yield | ||
|
||
sleep step | ||
raise Timeout::Error, 'wait took too long' if Mongo::Utils.monotonic_time - start > max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(EDIT: I just realized this function is a spec helper. However, I'll leave the comment below as I still think it's useful re: indexes in general)
A few points re: timeout. Firstly, we should agree that large collections (100M+ docs) are the canonical use case for search indexes.
- Indexing large collections takes a long time. Since this is done via a Rake task, it would be great if Mongoid could indicate the index building progress. (Atlas UI does this--you can see the % completion of index--so there is presumably some way Mongoid could as well.
- If you set socket_timeout in your Mongoid.yml--which also is a best practice--your index building here is going to timeout after 30 seconds. Index building should skip socket timeout entirely, since it happens in background anyway.
comandeo
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds helpers for declaring, creating, and removing atlas search indexes for Mongoid document models.