Skip to content

Use standard slices package instead of custom code #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use standard slices package instead of custom code #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions public/tools/multicluster/cmd/recover.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package cmd
import (
"fmt"
"os"
"slices"
"strings"

"github.com/mongodb/mongodb-kubernetes/multi/pkg/common"
Expand Down Expand Up @@ -68,12 +69,12 @@ kubectl-mongodb multicluster recover --central-cluster="operator-cluster" --memb
var RecoverFlags = common.Flags{}

func parseRecoverFlags(args []string) error {
if common.AnyAreEmpty(common.MemberClusters, RecoverFlags.ServiceAccount, RecoverFlags.CentralCluster, RecoverFlags.MemberClusterNamespace, RecoverFlags.CentralClusterNamespace, RecoverFlags.SourceCluster) {
if slices.Contains([]string{common.MemberClusters, RecoverFlags.ServiceAccount, RecoverFlags.CentralCluster, RecoverFlags.MemberClusterNamespace, RecoverFlags.CentralClusterNamespace, RecoverFlags.SourceCluster}, "") {
return xerrors.Errorf("non empty values are required for [service-account, member-clusters, central-cluster, member-cluster-namespace, central-cluster-namespace, source-cluster]")
}

RecoverFlags.MemberClusters = strings.Split(common.MemberClusters, ",")
if !common.Contains(RecoverFlags.MemberClusters, RecoverFlags.SourceCluster) {
if !slices.Contains(RecoverFlags.MemberClusters, RecoverFlags.SourceCluster) {
return xerrors.Errorf("source-cluster has to be one of the healthy member clusters: %s", common.MemberClusters)
}

Expand Down
3 changes: 2 additions & 1 deletion public/tools/multicluster/cmd/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"fmt"
"os"
"runtime/debug"
"slices"
"strings"

"github.com/mongodb/mongodb-kubernetes/multi/pkg/common"
Expand Down Expand Up @@ -75,7 +76,7 @@ kubectl-mongodb multicluster setup --central-cluster="operator-cluster" --member
var setupFlags = common.Flags{}

func parseSetupFlags() error {
if common.AnyAreEmpty(common.MemberClusters, setupFlags.ServiceAccount, setupFlags.CentralCluster, setupFlags.MemberClusterNamespace, setupFlags.CentralClusterNamespace) {
if slices.Contains([]string{common.MemberClusters, setupFlags.ServiceAccount, setupFlags.CentralCluster, setupFlags.MemberClusterNamespace, setupFlags.CentralClusterNamespace}, "") {
return xerrors.Errorf("non empty values are required for [service-account, member-clusters, central-cluster, member-cluster-namespace, central-cluster-namespace]")
}

Expand Down
21 changes: 0 additions & 21 deletions public/tools/multicluster/pkg/common/utils.go
View file
Open in desktop

This file was deleted.