Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove WithLabels in BuildMongoDBReplicaSetStatefulSetModificationFun #1612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove WithLabels in BuildMongoDBReplicaSetStatefulSetModificationFun #1612

wants to merge 1 commit into from

Conversation

usernameisnull
Copy link

@usernameisnull usernameisnull commented Sep 3, 2024 •
edited
Loading

…ction

Summary:

the label of sts is set by statefulSet.metadata.labels, via https://github.com/mongodb/mongodb-kubernetes-operator/blob/8e1a37b82521d9c49f6862ecd8f20596b422fa5a/controllers/replica_set_controller.go#L746C1-L747C1

so no need to invoke WithLabels in BuildMongoDBReplicaSetStatefulSetModificationFun, it will be override anyway

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@nammn nammn added the safe-to-test Add this label to PRs from forks to trigger E2E tests label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mircea-cosbuc mircea-cosbuc Awaiting requested review from mircea-cosbuc mircea-cosbuc is a code owner

@lsierant lsierant Awaiting requested review from lsierant lsierant is a code owner

@slaskawi slaskawi Awaiting requested review from slaskawi slaskawi is a code owner

@nammn nammn Awaiting requested review from nammn nammn is a code owner

@Julien-Ben Julien-Ben Awaiting requested review from Julien-Ben Julien-Ben is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
safe-to-test Add this label to PRs from forks to trigger E2E tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usernameisnull @nammn