-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Evergreen clean up and migration to use AWS secrets manager #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0883d01
to
aa153b2
Compare
Force pushed some cache changes 10th June. |
Normalize naming Group functions JAVA-5889
Leftover from JAVA-4502
Similar to the overall goals of JAVA-5891
JAVA-5896
JAVA-5849
${PREPARE_SHELL} | ||
rm -rf $DRIVERS_TOOLS || true | ||
|
||
"add-aws-auth-variables-to-file": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's difficult to compare some of the changes in this file. I don't think this is a problem, as long as we can confirm everything runs.
Have you confirmed that the task count is the same as before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the expected task count - previously was 728. Now its 729 - which accounts for the two extra k8s tests and the disabled serverless task.
.evergreen/.evg.yml
Outdated
params: | ||
shell: "bash" | ||
working_dir: "src" | ||
script: | | ||
${PREPARE_SHELL} | ||
JAVA_VERSION=${JAVA_VERSION} AWS_CREDENTIAL_PROVIDER=${AWS_CREDENTIAL_PROVIDER} .evergreen/run-mongodb-aws-test.sh assume-role | ||
|
||
"run aws auth test with aws EC2 credentials": | ||
"run-aws-auth-test-with-aws-EC2 credentials": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed a hyphen here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
JAVA_VERSION="${JAVA_VERSION}" \ | ||
AZUREKMS_KEY_VAULT_ENDPOINT=${testazurekms_keyvaultendpoint} AZUREKMS_KEY_NAME=${testazurekms_keyname} \ | ||
TESTS="testSlowOnly" .evergreen/run-tests.sh | ||
"run-slow-tests": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for the naming consistency
JAVA-5849
JAVA-5896
Changes since last review:
New full suite patch: https://spruce.mongodb.com/version/684a917f27c4e80007fbc250 |
Contains the following commits:
tasks
, andtask_groups
- allowing quicker navigation / searching for functions, tasks and task groups.evergreen validate ./.evergreen/.evg.yml
gradle-cache.sh
so that build artifacts can be included and used via thecreate-archive-tar-file
function.--no-build-cache
flags from scripts - it potentially hinders performance and wasn't required.