This repository has been archived by the owner on Jan 29, 2022. It is now read-only.
Allowing tuples such as ("a", "b") to be imported as ["a", "b"] #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the code, writeField#186 will pass the `toIgnore` as null, which will then be used in getTypeForBSON#154. If i need to get into that `if` block on mongodb#154, (with respect to the comments between 149-153) i just cannot, since fs[0].getName will have to be null for it to equal `toIgnore`. and if its null, it will just throw an NPE. All i want to do is create an array ["a", "b"] and that doesn't seem possible with the current code
|
Thanks for the patch but I'd really like to see some tests around this. The testing situation isn't great right now, however, and I'm trying to rectify that. I'll see if I can't get some time to get some better testing around this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the code,
writeField#186 will pass the
toIgnoreas null, which will then be used in getTypeForBSON#154.If i need to get into that
ifblock on #154, (with respect to the comments between 149-153) i just cannot, since fs[0].getName will have to be null for it to equaltoIgnore. and if its null, it will just throw an NPE.All i want to do is create an array ["a", "b"] and that doesn't seem possible with the current code