-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-31213 - streaming config #183
Merged
mongoKart
merged 67 commits into
mongodb:master
from
mongoKart:docsp-31213-streaming-config
Nov 14, 2023
Merged
DOCSP-31213 - streaming config #183
mongoKart
merged 67 commits into
mongodb:master
from
mongoKart:docsp-31213-streaming-config
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-smith721
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on all of this. I left some suggestions and questions but they're all pretty minor.
mongoKart
added a commit
that referenced
this pull request
Nov 14, 2023
(cherry picked from commit 7ab9ace)
mongoKart
added a commit
that referenced
this pull request
Nov 14, 2023
(cherry picked from commit 7ab9ace)
mongoKart
added a commit
that referenced
this pull request
Nov 14, 2023
(cherry picked from commit 7ab9ace)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-31213
Staging - https://preview-mongodbmongokart.gatsbyjs.io/spark-connector/docsp-31213-streaming-config/
Redirects w/ Staging Links
Self-Review Checklist