Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-31213 - streaming config #183

Merged
merged 67 commits into from
Nov 14, 2023
Merged

DOCSP-31213 - streaming config #183

merged 67 commits into from
Nov 14, 2023

Conversation

mongoKart
Copy link
Contributor

@mongoKart mongoKart commented Oct 13, 2023 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-31213
Staging - https://preview-mongodbmongokart.gatsbyjs.io/spark-connector/docsp-31213-streaming-config/

Redirects w/ Staging Links

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

@mongoKart mongoKart marked this pull request as ready for review November 6, 2023 17:35
jordan-smith721
jordan-smith721 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on all of this. I left some suggestions and questions but they're all pretty minor.

source/batch-mode/batch-read-config.txt Show resolved Hide resolved
source/java/read-from-mongodb.txt Outdated Show resolved Hide resolved
source/python/read-from-mongodb.txt Outdated Show resolved Hide resolved
source/scala/read-from-mongodb.txt Outdated Show resolved Hide resolved
source/configuration.txt Outdated Show resolved Hide resolved
source/includes/connection-write-config.rst Outdated Show resolved Hide resolved
source/includes/streaming-distinction.rst Outdated Show resolved Hide resolved
source/streaming-mode/streaming-read-config.txt Show resolved Hide resolved
source/streaming-mode/streaming-read.txt Outdated Show resolved Hide resolved
source/streaming-mode/streaming-read.txt Show resolved Hide resolved
@mongoKart mongoKart merged commit 7ab9ace into mongodb:master Nov 14, 2023
1 of 2 checks passed
@mongoKart mongoKart deleted the docsp-31213-streaming-config branch November 14, 2023 21:44
mongoKart added a commit that referenced this pull request Nov 14, 2023
@mongoKart
DOCSP-31213 - streaming config (#183)
45d7bce 
(cherry picked from commit 7ab9ace)
mongoKart added a commit that referenced this pull request Nov 14, 2023
@mongoKart
DOCSP-31213 - streaming config (#183)
5aed4af 
(cherry picked from commit 7ab9ace)
mongoKart added a commit that referenced this pull request Nov 14, 2023
@mongoKart
DOCSP-31213 - streaming config (#183)
7cceddf 
(cherry picked from commit 7ab9ace)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordan-smith721 jordan-smith721 jordan-smith721 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mongoKart @jordan-smith721