-
Notifications
You must be signed in to change notification settings - Fork 13
DOCSP-48763: Docker note #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ one fix to remove stacked admonitions
@@ -111,6 +111,10 @@ set ``myreplset``, which is running on port ``27017`` of three different hosts | |||
of its ``nodes`` attribute, the list might be empty while the client connects to | |||
the replica-set members. | |||
|
|||
.. note:: Replica Set in Docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is resulting in stacked note boxes which we should avoid, can the paragraph above this be taken out of an admonition? I think it works just as well without being in a note box
(cherry picked from commit c4ed87f)
(cherry picked from commit c4ed87f)
(cherry picked from commit c4ed87f)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48763
Staging Links
Self-Review Checklist