Skip to content

DOCSP-48763: Docker note #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

DOCSP-48763: Docker note #114

merged 2 commits into from
Apr 14, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Apr 14, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48763

Staging Links

  • connect/connection-targets
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Apr 14, 2025

    Deploy Preview for docs-c ready!

    Name Link
    🔨 Latest commit af21145
    🔍 Latest deploy log https://app.netlify.com/sites/docs-c/deploys/67fd2fb1aa41600008eff5ec
    😎 Deploy Preview https://deploy-preview-114--docs-c.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM w/ one fix to remove stacked admonitions

    @@ -111,6 +111,10 @@ set ``myreplset``, which is running on port ``27017`` of three different hosts
    of its ``nodes`` attribute, the list might be empty while the client connects to
    the replica-set members.

    .. note:: Replica Set in Docker
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Since this is resulting in stacked note boxes which we should avoid, can the paragraph above this be taken out of an admonition? I think it works just as well without being in a note box

    @mcmorisi mcmorisi merged commit c4ed87f into mongodb:master Apr 14, 2025
    2 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-48763 branch April 14, 2025 15:54
    mcmorisi added a commit that referenced this pull request Apr 14, 2025
    (cherry picked from commit c4ed87f)
    mcmorisi added a commit that referenced this pull request Apr 14, 2025
    (cherry picked from commit c4ed87f)
    mcmorisi added a commit that referenced this pull request Apr 14, 2025
    (cherry picked from commit c4ed87f)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants