Some minor improvements #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for MinKey and MaxKey in tojson()
Property should not be defined if already existing
Function not needed anymore with mongsh 2.3.1. See https://jira.mongodb.org/browse/MONGOSH-1859
This reverts commit a956e11.
addaleax
reviewed
Sep 26, 2024
| @@ -648,7 +653,7 @@ tojsonObject = function(x, indent, nolint, depth) { | |||
| if (typeof DBCollection != 'undefined' && val == DBCollection.prototype) | |||
| continue; | |||
|
|
|||
| fieldStrings.push(indent + "\"" + k + "\" : " + tojson(val, indent, nolint, depth + 1)); | |||
| fieldStrings.push(indent + k + ": " + tojson(val, indent, nolint, depth + 1)); | |||
There was a problem hiding this comment.
This breaks if k contains non-identifier characters, right? Just checking, this is already a bit broken either way (k couild probably also contain double quotes or backslashes)
There was a problem hiding this comment.
Yes, it was more a change for my personal needs.
I think I reverted it in 7c83f98 - I am not the expert yet with git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for MinKey and MaxKey
Check if property 'str' already exists on ObjectId
Remove function ISODate() for mongosh > 2.31.