ARROW-180 Support PyArrow 13 #168
Conversation
|
This problem has crept up again: It was previously addressed in apache/arrow#18582. I propose that on Ubuntu in CI, we build the wheels using Docker and then install from the wheel to match how the |
| # Whether to add the GLIBCXX override. | ||
| # Arrow's manylinux{2010, 2014} binaries are built with gcc <= 4.8 which predates CXX11 ABI | ||
| # - https://uwekorn.com/2019/09/15/how-we-build-apache-arrows-manylinux-wheels.html | ||
| ADD_GLIBCXX_OVERRIDE = os.environ.get("MONGO_ADD_GLIBCXX_OVERRIDE", "1") |
There was a problem hiding this comment.
This was what was causing the issue. The pyarrow wheels are now using manylinux_2_28, which has gcc 12.
|
The benchmarks will fail until the next PR, because the newer version of asv is properly failing when a benchmark fails. I've added the appropriate fixes in this PR. |
| @@ -84,7 +87,7 @@ jobs: | |||
|
|
|||
| make_sdist: | |||
| name: Make SDist | |||
| runs-on: ubuntu-latest | |||
| runs-on: macos-latest | |||
There was a problem hiding this comment.
Building on macOS instead of Ubuntu?
There was a problem hiding this comment.
This was an artifact from when Ubuntu wasn't working, but it doesn't matter either way.
| @@ -12,7 +12,7 @@ Command Line Tools. Additionally, you need CMake and pkg-config:: | |||
| $ brew install cmake | |||
| $ brew install pkg-config | |||
|
|
|||
| On Linux, you require gcc 4.8, CMake and pkg-config. | |||
| On Linux, you require gcc 12, CMake and pkg-config. | |||
There was a problem hiding this comment.
Minor nitpick, but we should probably change the wording to "installation requires ..."
|
Looks good, just a few minor comments! |
No description provided.