Skip to content

Commit

Permalink
try without gcc override
Browse files Browse the repository at this point in the history
  • Loading branch information
blink1073 committed Sep 12, 2023
1 parent 67365a1 commit 9defbf1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/test-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ jobs:
python-version: ${{ matrix.python-version }}
cache: 'pip'
cache-dependency-path: '**/setup.cfg'
allow-prereleases: true
- name: Start MongoDB
uses: supercharge/[email protected]
with:
Expand All @@ -116,7 +117,7 @@ jobs:
- name: Install pyarrow
run: |
#sudo apt-get install -y build-essential cmake python3-dev python3.10-venv libssl-dev
./build-pyarrow.sh
#./build-pyarrow.sh
- name: Install the project with test dependencies
run: |
python -m pip install -v -e ".[test]"
Expand Down
8 changes: 0 additions & 8 deletions bindings/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@
# Whether to create libarrow symlinks on posix systems.
CREATE_LIBARROW_SYMLINKS = os.environ.get("MONGO_CREATE_LIBARROW_SYMLINKS", "1")

# Whether to add the GLIBCXX override.
# Arrow's manylinux{2010, 2014} binaries are built with gcc <= 4.8 which predates CXX11 ABI
# - https://uwekorn.com/2019/09/15/how-we-build-apache-arrows-manylinux-wheels.html
ADD_GLIBCXX_OVERRIDE = os.environ.get("MONGO_ADD_GLIBCXX_OVERRIDE", "1")

# Set a default value for MACOSX_DEPLOYMENT_TARGET.
os.environ.setdefault("MACOSX_DEPLOYMENT_TARGET", "10.15")

Expand Down Expand Up @@ -157,9 +152,6 @@ def append_arrow_flags(ext):
if os.name == "posix":
ext.extra_compile_args.append("-std=c++17")

if ADD_GLIBCXX_OVERRIDE:
ext.extra_compile_args.append("-D_GLIBCXX_USE_CXX11_ABI=0")

elif os.name == "nt":
ext.extra_compile_args.append("/std:c++17")

Expand Down

0 comments on commit 9defbf1

Please sign in to comment.