Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Actions and Add Python-Specific Actions #6

Merged
merged 40 commits into from
May 23, 2024
Merged

Refactor Actions and Add Python-Specific Actions #6

merged 40 commits into from
May 23, 2024

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented May 22, 2024 •
edited
Loading

  • Add a top-level setup action that handles secrets from AWS and sets up environment
  • Change git-sign and gpg-sign to use the file and environment variables created in setup
  • Rename the papertrail action to be more generic
  • Add opinionated python actions for bump-and-tag, and publishing.
  • We will need to tag current main as v1 and call this v2.
  • Update top level readme
  • Tested with PYTHON-4417 Use refactored actions from drivers-github-tools mongodb/winkerberos#86

@blink1073 blink1073 mentioned this pull request May 22, 2024
Merged
@blink1073 blink1073 requested a review from alcaeus May 22, 2024 11:49
@blink1073 blink1073 marked this pull request as ready for review May 22, 2024 11:49
alcaeus
alcaeus requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback. Note that I haven't reviewed the Python action and would defer to someone from the Python team for that.

README.md Outdated Show resolved Hide resolved
setup/setup.sh Outdated Show resolved Hide resolved
setup/action.yml Show resolved Hide resolved
setup/action.yml Outdated Show resolved Hide resolved
gpg-sign/action.yml Outdated Show resolved Hide resolved
blink1073 and others added 4 commits May 22, 2024 08:00
@blink1073 @alcaeus
Update README.md
feb4927 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update setup/setup.sh
5e015f2 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update setup/action.yml
820e05c 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073
address review
5e8749a
NoahStapp
NoahStapp requested changes May 22, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
python/bump-and-tag/action.yml
version:
description: "The published version"
required: true
post_version:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post_version is a little ambiguous: I'd prefer to rename this something more explicit like following_version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

python/publish/publish.sh Outdated
gh release upload ${VERSION} $RELEASE_ASSETS/*.*
gh release view ${VERSION} >> $GITHUB_STEP_SUMMARY
else
echo "Dry run, not uploading to s3 or creating GitHub Release"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have the dry run print information about what it would have published?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

blink1073 and others added 2 commits May 22, 2024 11:13
@blink1073 blink1073 requested a review from NoahStapp May 22, 2024 16:17
NoahStapp
NoahStapp requested changes May 22, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@blink1073 @NoahStapp
Update README.md
681f180 
Co-authored-by: Noah Stapp <[email protected]>
@blink1073 blink1073 requested a review from NoahStapp May 22, 2024 17:36
alcaeus
alcaeus approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

alcaeus
alcaeus reviewed May 23, 2024
View reviewed changes
Copy link
Collaborator

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion to use the v2 tag in the readme, but since we haven't tagged it yet I'll let you decide whether you want to make the change now or defer until later.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
blink1073 and others added 14 commits May 23, 2024 08:23
@blink1073 @alcaeus
Update README.md
b301d21 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
2e38f3e 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
8f856b3 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
4b1ec7c 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
3469d9b 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
d5a82e7 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
233cdd8 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
252f68b 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
b08290e 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
310a732 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
1f1d6e6 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
34d18e3 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 @alcaeus
Update README.md
f5eb095 
Co-authored-by: Andreas Braun <[email protected]>
@blink1073
add note about actions/checkout
b2918e9
@blink1073 blink1073 requested a review from alcaeus May 23, 2024 13:28
@blink1073 blink1073 merged commit a1f9615 into mongodb-labs:main May 23, 2024
1 check passed
@blink1073 blink1073 deleted the refactor branch May 23, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

@NoahStapp NoahStapp NoahStapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blink1073 @alcaeus @NoahStapp