-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up gpg-sign and papertrail actions #5
Conversation
@@ -54,5 +54,5 @@ runs: | |||
-v $(pwd):$(pwd) \ | |||
-w $(pwd) \ | |||
${{ inputs.artifactory_registry }}/${{ inputs.artifactory_image }} \ | |||
/bin/bash -c 'gpgloader && for filename in "${{ inputs.filenames }}"; do gpg --detach-sign --armor --output ${filename}.sig ${filename}; done' | |||
/bin/bash -c 'gpgloader && for filename in ${{ inputs.filenames }}; do gpg --detach-sign --armor --output ${filename}.sig ${filename}; done' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I was under the assumption that the space separated lists needed to be quoted. This is much better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would have. We only support single filenames or a glob pattern now. But it was surprisingly difficult to generate a space separated list from a directory listing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Works for me 👍
Example run: https://github.com/blink1073/winkerberos/actions/runs/9024423244/job/24798319965