Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add papertrail action #4

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from alcaeus May 8, 2024 11:06
Copy link
Collaborator

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't yet tested it yet, but looks good after a first look.

I'm a little concerned how this will fit the workflow. Take PHP for example: triggering the release is done by a user, but the build artifacts are only built later after the release tag has been pushed by the automation. So, in order for us to include hashes for generated artifacts, we'd have to wait until after packaging, but we no longer have information about who triggered the release build at that point.

@@ -13,7 +13,8 @@ GPG key.
### git-sign

Use this action to create signed git artifacts:
```markdown

```yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ Thanks!

required: true
token:
description: "The GitHub token for the action"
required: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use default: ${{ github.token }} here or does that not work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from within an action, "Note: This context property is set by the Actions runner, and is only available within the execution steps of a job."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. No problem then 👍

papertrail/action.yml Outdated Show resolved Hide resolved
Co-authored-by: Andreas Braun <[email protected]>
@blink1073 blink1073 requested a review from alcaeus May 8, 2024 11:25
@blink1073
Copy link
Member Author

I'm a little concerned how this will fit the workflow. Take PHP for example: triggering the release is done by a user, but the build artifacts are only built later after the release tag has been pushed by the automation. So, in order for us to include hashes for generated artifacts, we'd have to wait until after packaging, but we no longer have information about who triggered the release build at that point.

Yes, we have to run everything in a single workflow. See mongodb/winkerberos#76 for how that works with the workflow_call.

@blink1073 blink1073 merged commit 08c9ab0 into mongodb-labs:main May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants