Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to bump and tag actions #33

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

alcaeus
Copy link
Collaborator

@alcaeus alcaeus commented Jun 13, 2024

This PR contains a few changes to the bump-version and tag-commit actions:

  • Changed the default tag message to "Release ${VERSION}" instead of "BUMP ${VERSION}" - I assumed the latter was wrong as it's the same as the bump commit
  • Changed output style of the "created commit/tag" messages to no longer appear as headings in the build output
  • Made the version_bump_script input in bump_version optional - this can be useful to skip the bump step if it happens before (as is the case in PHP where we bump earlier to sanity-check the input before starting the release process)
  • (nit) Cleaned up style of variable usage

@alcaeus alcaeus requested a review from blink1073 June 13, 2024 11:06
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alcaeus alcaeus merged commit 7edc545 into mongodb-labs:main Jun 13, 2024
3 checks passed
@alcaeus alcaeus deleted the tag-bump-improvements branch June 13, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants