fix queries when subquery has a union #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibola
approved these changes
Nov 18, 2024
| @@ -469,6 +472,7 @@ def get_combinator_queries(self): | |||
| ) | |||
| ) | |||
| compiler_.pre_sql_setup() | |||
| compiler_.column_indices = self.column_indices | |||
There was a problem hiding this comment.
If self.column_indices is a list, should we copy it instead?
There was a problem hiding this comment.
No, passing by reference was on purpose, the compiler in a union query is made by multiples compilers, so those sub-compilers could use some field from the parent's parent query, then column_indices should be shared.
timgraham
changed the title
timgraham
changed the title
timgraham
force-pushed
the
bugfix-Union-Subquery-Not-Mapping-Parent-Parameters-and-Collections-Properly
branch
from
b69eb7e to
6f37da1
Compare
WaVEV
changed the title
WaVEV
changed the title
timgraham
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #156